forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
Export ts namespace from tsserver for hacky-post patching #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce3b98c
to
1d92ee1
Compare
586a05e
to
5b31ac2
Compare
1d92ee1
to
e5d5826
Compare
5b31ac2
to
7a5cd70
Compare
e5d5826
to
cdac21e
Compare
7a5cd70
to
d38dfd9
Compare
cdac21e
to
1ecfbcf
Compare
d38dfd9
to
9ca6bf1
Compare
c71f45d
to
a2e8cb7
Compare
9ca6bf1
to
175d525
Compare
a2e8cb7
to
7b1db7c
Compare
175d525
to
14ab6a6
Compare
7b1db7c
to
ff36738
Compare
14ab6a6
to
f10b875
Compare
ff36738
to
61928b0
Compare
f10b875
to
d3deabd
Compare
61928b0
to
b7adab0
Compare
d3deabd
to
f0607de
Compare
b7adab0
to
c3318c8
Compare
e4bcd8e
to
2925d14
Compare
a1f24e5
to
ac72e75
Compare
4a0a771
to
0708798
Compare
fa324cf
to
42b025a
Compare
0708798
to
35d4b72
Compare
42b025a
to
31f678e
Compare
35d4b72
to
b3b2ea3
Compare
31f678e
to
0b39e4c
Compare
b3b2ea3
to
6d144e1
Compare
0b39e4c
to
a7e9ea1
Compare
6d144e1
to
a27dbb6
Compare
a7e9ea1
to
f85c56f
Compare
a27dbb6
to
cd922a6
Compare
f85c56f
to
8365adc
Compare
cd922a6
to
375e65c
Compare
8365adc
to
a3a8116
Compare
375e65c
to
dbfacd0
Compare
a3a8116
to
ccedf5c
Compare
dbfacd0
to
7135ee3
Compare
ccedf5c
to
c735079
Compare
7135ee3
to
500db6f
Compare
c735079
to
d858137
Compare
500db6f
to
4a472cd
Compare
d858137
to
4df0c02
Compare
4a472cd
to
e1fe2d4
Compare
4df0c02
to
4a0be1d
Compare
e1fe2d4
to
0d0089e
Compare
Unlike our other exectuables, tsserver is used in web, which means that there actually would have been a "ts" variable declared for those users (e.g. in a web worker). It looks like VS Code needs this variable to be declared, so change this bundle to look the same as other libraries. Note that in Node, the IIFE will never actually return, so this can have no effect. On web, it will return in order to yield control back to the event loop (as on web, postMessage is used to communicate).
4a0be1d
to
37d74bb
Compare
0d0089e
to
2607563
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike our other exectuables, tsserver is used in web, which means that
there actually would have been a "ts" variable declared for those users
(e.g. in a web worker). It looks like VS Code needs this variable to be
declared, so change this bundle to look the same as other libraries.
Note that in Node, the IIFE will never actually return, so this can have
no effect. On web, it will return in order to yield control back to the
event loop (as on web, postMessage is used to communicate).
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: